Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image is always pulling even if build documentation step is conditional and inactive #14

Open
VladimirRybalko opened this issue Jan 5, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@VladimirRybalko
Copy link

VladimirRybalko commented Jan 5, 2022

I have the below step in my workflow.

- name: Build Documentation
   if: ${{ github.ref_name == 'master' && github.event_name == 'push' }}
   uses: nikeee/[email protected]
   with:
     args: docs/docfx.json

As you see the step is conditional, however docker image is always pulling independently on step status.

This is what I see in the workflow logs:
Screenshot 2022-01-05 at 17 10 23

It's definitely not good. It takes 30 seconds every time for nothing even if docfx is not needed.

Could you please have a look?

@nikeee nikeee added the help wanted Extra attention is needed label Jan 5, 2022
@robtimus
Copy link

I think this is something that GitHub does for all actions. I've seen some of my own builds always start with creating Docker images. I think this is something you can better check with GitHub.

@nikeee
Copy link
Owner

nikeee commented Apr 19, 2023

I think this is a limitation of the way docker actions work.

Maybe we should consider removing docker entirely. Docker was used to get a consistent behaviour across all OS runners. Since .NET now runs properly on Linux/Mac, this problem went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants