-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode #36
Comments
That would be possible and I also thought about that. The thing is that we need to style the rendered graph accordingly. This becomes a problem if the user styles his graph with DOT attributes. Possible solutions:
|
You're right, a manual switch should be provided in addition to automatic detection.
That's a general problem with Dark mode. It seems like most gvs assume a white background. How about we do this: In dark mode, there are two ways to display the graph container.
The final result will look like this with inverted colors: And like this without inverted colors: It looks ok but there are a few problems with this approach:
There are also browser plugins that can achieve better results. E.g. this is what the Chrome Dark Reader plugin produced: Colors look good and fonts AA looks good as well. But they seem to use a rather complex approach. |
That being said, it will probably be enough to only change the editor theme rn. Black on one side and white on the other side doesn't look bad IMO. |
It wouldn't be black either. The editor has a dark mode built-in, which I'd use for that. Maybe applying a CSS filter (as you proposed) would suffice (instead of styling the SVG elements directly). |
I also used that one for the screenshots. Seems pretty black to me. |
Thank you for the great tool!
Would it be possible to add a dark mode and that the theme (light/dark) is automatically chosen depending on the user's configured preference?
The text was updated successfully, but these errors were encountered: