Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with React v16.0.0. #344

Open
eddiekollar opened this issue Oct 6, 2017 · 6 comments
Open

Incompatible with React v16.0.0. #344

eddiekollar opened this issue Oct 6, 2017 · 6 comments

Comments

@eddiekollar
Copy link

Similar error message as in #330 :
Module not found: Can't resolve 'react-dom/lib/CSSPropertyOperations'

@nikgraf
Copy link
Owner

nikgraf commented Oct 10, 2017

Back then we could solved it by moving the import, but at this point functionality must be extracted from the React repo.

@eddiekollar Are you interested to do that? Here is the file: https://github.com/facebook/react/blob/2566b2420b714c00b3a456b8d744a26387eaf511/src/renderers/dom/shared/CSSPropertyOperations.js
All the required imports would also be need to be pulled in

@eddiekollar
Copy link
Author

@nikgraf Yes, I would be happy to.

@nikgraf
Copy link
Owner

nikgraf commented Oct 16, 2017

@eddiekollar awesome, looking forward to your PR :)

btw another alternative would be to switch to styled-components for example. Either way if fine for me. Happy to accept PRs :)

@frontmaker
Copy link

frontmaker commented Dec 4, 2017

@nikgraf I started working on switching to styled-components.Here is my fork https://github.com/frontmaker/belle. Will be glad for any help or advices.

@shahabhinandan
Copy link

Guys, is there any update on compatibility of latest React version? Is there a workaround without downgrading React?

@testacode
Copy link

fuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants