Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Patching from different sources #550

Open
1 task done
sawankumarbundelkhandi opened this issue Aug 15, 2024 · 3 comments
Open
1 task done

Multi Patching from different sources #550

sawankumarbundelkhandi opened this issue Aug 15, 2024 · 3 comments
Assignees
Labels
feature-request👓 New feature request help wanted Extra attention is needed

Comments

@sawankumarbundelkhandi
Copy link
Contributor

Support guidelines

Description

It would be useful to allow multi patching - using the patched output apk as input to patches from other creators.

Motivation

If I need to patch Spotify, I would first utilize the "Change Package Name" patch from the ReVanced project, given that Spotify is pre-installed on my device. This patch can be found on the ReVanced GitHub repository here. After adjusting the package name, I would proceed with applying the necessary Spotify-specific patches from the Dropped Patches repository, which are available here

I can use the same for picking from patches from Revanced and then some from Revanced Extended for youtube.

Additional Context

Rename package patch - https://github.com/ReVanced/revanced-patches/
Spotify premium patch - https://github.com/indrastorms/Dropped-Patches/

@sawankumarbundelkhandi
Copy link
Contributor Author

@nikhilbadyal just found this - indrastorms/Dropped-Patches#62

Maybe we can use - bundle with cli using -b revanced.jar -b dropped-patches.jar. Does docker-py-revanced support passing multiples bundle?

@IMXEren
Copy link
Contributor

IMXEren commented Aug 15, 2024

Not currently and choosing an appropriate seperator is another question.

I think it'd good to use variables in env. For example:

S1JAR=https://github.com/ReVanced/revanced-patches
S2JAR=https://github.com/indrastorm/Dropped-patches
SPOTIFY_PATCHES_DL=@S1JAR,@S2JAR  ## or $ instead of @

I think this would be better than inline. Undefined variables should raise an error.

@nikhilbadyal
Copy link
Owner

As stated by @IMXEren , currently builder doesn't support multiple bundles.
Unfortunately I'm busy for a while so might not be able to implement it as well. Will appreciate if you/anyone can raise a PR. I'll be happy to review it.

@nikhilbadyal nikhilbadyal added the help wanted Extra attention is needed label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request👓 New feature request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants