Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode decimal fractions #27

Merged
merged 5 commits into from
Nov 29, 2024
Merged

hardcode decimal fractions #27

merged 5 commits into from
Nov 29, 2024

Conversation

nikolaydubina
Copy link
Owner

closes #26

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.96%. Comparing base (878c2f4) to head (2f9c004).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
fp3/fpdecimal.go 90.00% 1 Missing ⚠️
fp6/fpdecimal.go 98.07% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #27      +/-   ##
===========================================
- Coverage   100.00%   98.96%   -1.04%     
===========================================
  Files            3        4       +1     
  Lines          141      193      +52     
===========================================
+ Hits           141      191      +50     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikolaydubina nikolaydubina merged commit 98f7525 into master Nov 29, 2024
3 of 5 checks passed
@nikolaydubina nikolaydubina deleted the split branch November 29, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove package level FractionDigits
1 participant