Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message queue initialization should be done in a component #6

Open
zzat opened this issue Dec 19, 2023 · 0 comments
Open

Message queue initialization should be done in a component #6

zzat opened this issue Dec 19, 2023 · 0 comments

Comments

@zzat
Copy link
Collaborator

zzat commented Dec 19, 2023

Instead of making the message queue as a singleton, init it in a component and pass it as a dependency to the http server.
This forces us to pass the message queue explicitly to the functions instead of using the singleton queue. This helps in testing as we can use different queues for different tests and not depend on one globally defined queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant