Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpecomp_2_2.py _is_valid_edition() always returns true #37

Open
MinamiSun opened this issue Nov 17, 2018 · 1 comment
Open

cpecomp_2_2.py _is_valid_edition() always returns true #37

MinamiSun opened this issue Nov 17, 2018 · 1 comment
Labels

Comments

@MinamiSun
Copy link

Hi , as the title mentioned, _is_valid_edition() in cpecomp_simple.py has a function _is_valid_edition(), which get the value from _is_valid_value() from cpecomp_2_2.py if we use this standard. _is_valid_value() returns true or false , _is_valid_edition() returns _is_valid_value() is None, which should always be true.

@nilp0inter
Copy link
Owner

You are right. I think we lack some testing here. I'll be doing a new test set and a patch for this in the following days.

Thank you!

@creekorful creekorful added the bug label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants