Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: adopt semver, like almost all nimble packages #30

Open
timotheecour opened this issue Oct 19, 2020 · 0 comments
Open

RFC: adopt semver, like almost all nimble packages #30

timotheecour opened this issue Oct 19, 2020 · 0 comments

Comments

@timotheecour
Copy link
Member

timotheecour commented Oct 19, 2020

right now fusion.nimble is stuck at 1.0 (I wished it didn't start out at 1.0, packages should always start at some 0.x.y).
This proposal is to start adopting semver; anything is better than the current approach, eg:

  • breaking changes likely to break code (which should be minimized but sometimes are the lesser evil) bump minor
  • api additions bump patch
  • nim should start referring to point releases instead of arbitrary looking FusionStableCommit = "319aac4d43b04113831b529f8003e82f4af6a4a5"
  • we can also distinguish odd vs even minor and patch as is done in nim, with rationale that fusion 1.2x.2y even is more stable than 1.(2x+1).(2y+1)

note that any change (including an API addition) can be considered breaking changes in nim (eg, causing a redefinition error when fusion defines bar which was otherwise in some 3rd party import), so practicality trumps 0 breaking changes.

links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant