Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace magic functions with plain functions #13

Closed
ringabout opened this issue Oct 28, 2021 · 2 comments
Closed

replace magic functions with plain functions #13

ringabout opened this issue Oct 28, 2021 · 2 comments

Comments

@ringabout
Copy link
Contributor

ringabout commented Oct 28, 2021

abs

timotheecour/Nim#476
timotheecour/Nim#485

swap (JS backend)

nim-lang/Nim#16778

@saem
Copy link
Collaborator

saem commented Oct 30, 2021

A procedural note: Please don't link Tim's PRs as the only body of a ticket. I have no interest trying to decipher his writing style, let alone looking through all the code line by line spotting issues or worse not because of accidental complexity. Tim's style might work great for him or the nim compiler but it's an absolute non-starter for me.

What the title of this issue seems to suggest might be a good idea, but I want to hear about what impacts we expect to see in terms of the current mission.

For example nkError:

  • allows us to rework large parts of sem to be linear in control flow and or functions
  • separate code into query, judgement, and production
  • ease the implementation of IC
  • improve error messages

The power to weight ratio is high as you can see, what's it like for magics?

@saem
Copy link
Collaborator

saem commented Nov 5, 2021

Guessing this wasn't important since I didn't get a reply.

@saem saem closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants