Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements_parent_selector ignore custom_add_location #166

Open
Aterkop opened this issue Apr 3, 2020 · 0 comments
Open

elements_parent_selector ignore custom_add_location #166

Aterkop opened this issue Apr 3, 2020 · 0 comments

Comments

@Aterkop
Copy link

Aterkop commented Apr 3, 2020

Hi there,
In my project I want to add collection element in tab content with add buton in tab header. For that I use :

  • after_add function : to add tab header foreach new element
  • custom_add_location : to use a custom button in tab header
  • elements_parent_selector : to automatically add my collection element into tab content div

The 2 fisrts elements works as espected but when I add elements_parent_selector, a standard add button is added at the end of my tab-content (my elements_parent_selector). The elements_parent_selector ignores custom_add_location.
I fix it by adding
if (settings.add && !settings.custom_add_location) {
to jquery.collection.js line 345.
Please see if you can fix it for a future release.
Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant