Cannot automatically import multiple levels of nested directories under utils

[noootwo]

Environment

• Operating System: Linux
• Node Version: v18.20.3
• Nitro Version: 2.10.4
• Package Manager: [email protected]

Reproduction

https://stackblitz.com/edit/github-pxnqrn?file=server%2Futils%2Findex.ts,server%2Futils%2Ffoo%2Fbar%2Findex.ts,server%2Futils%2Ffoo%2Findex.ts,server%2Froutes%2Findex.ts

Describe the bug

Cannot automatically import multi-level of nested directories under server/utils.

In unimportversion 3.13 and earlier, auto-importing worked for two levels.
However, in unimport version 3.14, it only works for one level.

Additional context

Is automatically import of multi-level(>3) directories expected behavior?

Logs

No response

[pi0]

/cc @antfu any clues? (i haven't checked anything yet but imagined you might have better context for resolution 🙏🏼 )

[noootwo]

@pi0 If auto import multi-level directories is the desired behavior, I can submit a PR to fix this issue

[antfu]

/cc @antfu any clues? (i haven't checked anything yet but imagined you might have better context for resolution 🙏🏼 )

Explaining the context:

@noootwo worked on the PRs to unimport that changed a bit of how dirs's root is resolved, which landed in [email protected] and caused some behavior change in nitro. It was because Nitro put utils/* in dirs (

nitro/src/core/config/resolvers/imports.ts

Line 30 in 575144f

...options.scanDirs.map((dir) => join(dir, "utils/*"))

) instead of utils. Previously, it was resolved as utils/**/*.{ts,js}, but now it is resolved to utils/*.{ts,js}. This issue was mainly asking about what's your original expectation of it, if you was expecting utils to resolve to nested folder, we would fix it in unimport.

My two cents:

I think we should fix that in unimport to align with the previous behavior. Otherwise it would be a breaking change to existing Nitro users anyway. Even if it was not a designed behavior (which to me it seems to expect to be deep), we could figure out a way to smooth it out and make the breakage in a major of nitro.

[noootwo]

/cc @antfu any clues? (i haven't checked anything yet but imagined you might have better context for resolution 🙏🏼 )

Explaining the context:

@noootwo worked on the PRs to unimport that changed a bit of how dirs's root is resolved, which landed in [email protected] and caused some behavior change in nitro. It was because Nitro put utils/* in dirs (

nitro/src/core/config/resolvers/imports.ts

Line 30 in 575144f

...options.scanDirs.map((dir) => join(dir, "utils/*"))

) instead of utils. Previously, it was resolved as utils/**/*.{ts,js}, but now it is resolved to utils/*.{ts,js}. This issue was mainly asking about what's your original expectation of it, if you was expecting utils to resolve to nested folder, we would fix it in unimport.

My two cents:

I think we should fix that in unimport to align with the previous behavior. Otherwise it would be a breaking change to existing Nitro users anyway. Even if it was not a designed behavior (which to me it seems to expect to be deep), we could figure out a way to smooth it out and make the breakage in a major of nitro.

Correct a small error described here, previously, it was resolved as utils/* and utils/*/*.{ts,js}, so it can match the first and second levels files of the utils directory.

So if expect to match deep-level files, there were also some issues before.: )

[noootwo]

So I tend to prefer maintaining the current unimport behavior, that better aligns with the intuitive understanding of the dirs option.

This means that need to change utils/* to utils/**/* in nitro.

If my understanding is off track, please correct me, thanks.

[antfu]

Yeah I agree that only two-level nesting is confusing, it should be either one level or deep. /cc @pi0 WDYT?