Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty.shellIntegration: document that shells need to be enabled in home manager #6197

Open
ksyx opened this issue Dec 11, 2024 · 4 comments
Open
Assignees

Comments

@ksyx
Copy link

ksyx commented Dec 11, 2024

Description

Currently, programs.kitty.shellIntegration.enable*Integration seemed to require respective shells to be enabled. With its default calculated by !(elem "disabled" (splitString " " config.programs.kitty.shellIntegration.mode)), which seemed to be true for all shells by default if integration mode is set to something enabling. Hence, to reduce confusion of not getting the integration after enabling, it may worth adding a note that these options depends on programs.<shell>.enable=true to work, in the descriptions of these options.

@ksyx
Copy link
Author

ksyx commented Dec 11, 2024

@Scrumplex Please see if this is worth adding

@Scrumplex
Copy link
Member

I think the conditionals should be somewhat flipped for those options. Maybe set their default value to programs.<shell>.enable and just make it a noop if shell integration is disabled.

@ksyx
Copy link
Author

ksyx commented Dec 11, 2024

Oh this sounds even better!

@rigille
Copy link

rigille commented Jan 10, 2025

Thanks! I was so confused about why shell integration wasn't working before reading this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants