Retain meta from wrapper script during buildEnv #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, no metadata is set for the environment, which leads to the wrong assumption that the main program used when running the environment equals the package name. In our case this is the original package name prefixed with "nixpak-". However, the wrapper script is named like the original main program, which leads to errors like the following when running the environment: error: unable to execute '/nix/store/apnm35wckzlq4nqcmk3zpwys07srn9y4-nixpak-ungoogled-chromium-127.0.6533.99/bin/nixpak-ungoogled-chromium': No such file or directory This commit retains the metadata from the wrapper script when building the environment, which also copies meta.mainProgram. Therefore, the correct main program is detected when running the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no metadata is set for the environment, which leads to the wrong assumption that the main program used when running the environment equals the package name. In our case this is the original package name prefixed with "nixpak-".
However, the wrapper script is named like the original main program, which leads to errors like the following when running the environment:
This commit retains the metadata from the wrapper script when building the environment, which also copies
meta.mainProgram. Therefore, the correct main program is detected when running the environment.This might also partly fix nixpak/pkgs#24.