From 03879c9661c9a3de8b4a85c0d0bc75fb999912aa Mon Sep 17 00:00:00 2001
From: Nathan Jaremko <nathan@jaremko.ca>
Date: Sun, 23 Jun 2024 21:35:25 -0400
Subject: [PATCH] Minor cleanup

---
 src/idp/verified_request.rs | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/idp/verified_request.rs b/src/idp/verified_request.rs
index 11919bc..461ae26 100644
--- a/src/idp/verified_request.rs
+++ b/src/idp/verified_request.rs
@@ -18,7 +18,7 @@ impl<'a> UnverifiedAuthnRequest<'a> {
         })
     }
 
-    pub fn get_certs_der(&self) -> Result<Vec<Vec<u8>>, Error> {
+    fn get_certs_der(&self) -> Result<Vec<Vec<u8>>, Error> {
         let x509_certs = self
             .request
             .signature
@@ -26,13 +26,11 @@ impl<'a> UnverifiedAuthnRequest<'a> {
             .ok_or(Error::NoSignature)?
             .key_info
             .as_ref()
-            .map(|ki| ki.iter().next()) // TODO: why only the first key?
-            .unwrap_or(None)
+            .map(|ki| ki.iter())
             .ok_or(Error::NoKeyInfo)?
-            .x509_data
-            .iter()
+            .flat_map(|d| d.x509_data.as_ref())
             .flat_map(|d| d.certificates.iter())
-            .map(|cert| crypto::decode_x509_cert(cert.as_str()))
+            .map(|cert| crypto::decode_x509_cert(cert))
             .collect::<Result<Vec<_>, _>>()
             .map_err(|_| Error::InvalidCertificateEncoding)?;
 
@@ -49,7 +47,7 @@ impl<'a> UnverifiedAuthnRequest<'a> {
             .into_iter()
             .map(|der_cert| Ok(verify_signed_xml(xml, &der_cert, Some("ID"))?))
             .reduce(|a, b| a.or(b))
-            .unwrap()
+            .ok_or(Error::UnexpectedError)?
             .map(|()| VerifiedAuthnRequest(self.request))
     }