Remove adapters #4
Conversation
Create ContinuousInegration.yml
|
This doesn't have any changes related to the adapters. Did you forget to push a commit that changed the cmake files? |
|
Sorry, I forgot one last push. It should all be there now. |
There was a problem hiding this comment.
This does compile just fine, but you've ended up adding spdlog's test suite into the list of targets. Do you know if those can be disabled? I'm guessing this would actually include the spdlog tests as targets for all upstream repositories as well, which isn't our normal process.
| GIT_TAG origin/build/fetchcontent | ||
| FetchContent_Declare( spdlog | ||
| GIT_REPOSITORY https://github.com/gabime/spdlog.git | ||
| GIT_TAG a51b4856377a71f81b6d74b9af459305c4c644f8 | ||
| GIT_SHALLOW TRUE |
There was a problem hiding this comment.
This will get fixed later, but FYI, you don't need GIT_SHALLOW when GIT_TAG points to a hash or tag. It only has meaning for branches.
There was a problem hiding this comment.
You beat me to it. I was about to do the same thing.
|
I fixed it and pushed. I'll have to debate as to whether the commands make sense where I put them or if I should have put them in the main CMakeLists.txt file. But this will work for now. |
|
We still have the spdlog-utests being built. |
|
It worked for me before, but not now -- weird. I think I can fix it. |
This removes the need for spdlog-adapter and fmt-adapter.
This also adds the unit testing back in, which was previously removed.