Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RECONR #118

Open
wants to merge 70 commits into
base: release/v1.3.0
Choose a base branch
from
Open

RECONR #118

wants to merge 70 commits into from

Conversation

jlconlin
Copy link
Member

This Pull Request adds the modern RECONR module to NJOY21.

jlconlin and others added 30 commits November 4, 2019 17:14
# Conflicts:
#	CMakeLists.txt
#	metaconfigure/description.json
But that modern component isn't done yet.
# Conflicts:
#	CMakeLists.txt
#	src/njoy21.hpp
# Conflicts:
#	CMakeLists.txt
#	cmake/develop_dependencies.cmake
#	src/njoy21.hpp
#	src/njoy21/Driver/Factory/src/setupModernDirectory.hpp
#	src/njoy21/modern.hpp
#	src/njoy21/modern/Sequence/Factory.hpp
#	src/njoy21/modern/Sequence/Factory/src/parse.hpp
#	src/njoy21/modern/Sequence/routines.hpp
#	tests/47/CMakeLists.txt
#	tests/47/referenceTape45
#	tests/47/referenceTape47
#	tests/47/referenceTape55
#	tests/47/referenceTape57
#	tests/48/CMakeLists.txt
#	tests/49/CMakeLists.txt
#	tests/49/input
#	tests/49/referenceTape71
#	tests/50/CMakeLists.txt
#	tests/50/referenceTape33
#	tests/50/referenceTape34
#	tests/51/CMakeLists.txt
#	tests/51/referenceTape33
#	tests/51/referenceTape34
#	tests/52/CMakeLists.txt
#	tests/52/referenceTape33
#	tests/52/referenceTape34
#	tests/53/CMakeLists.txt
#	tests/53/referenceTape33
#	tests/53/referenceTape34
#	tests/54/CMakeLists.txt
#	tests/54/referenceTape33
#	tests/54/referenceTape34
@jlconlin jlconlin mentioned this pull request Jan 22, 2021
@jlconlin
Copy link
Member Author

The latest update 54e82e2 moves this Pull Request out of draft mode.

  • Tests have been update to reflect changes due to modern LEAPR and RECONR.
  • Eight tests have been deleted as the ENDF files they use are old (i.e., < ENDF/B-VII.0) and no longer supported. This is documented in the ReleaseNotes
  • Three tests have been ignored using cmake/CTestCustom.cmake

The attached RegressionTests.pdf shows the checks that have been done to try and identify what the changes are in the all the regression tests.

@jlconlin jlconlin changed the base branch from release/v1.2.0 to release/v1.3.0 March 18, 2021 15:11
@jlconlin jlconlin marked this pull request as ready for review March 18, 2021 15:12
@jlconlin jlconlin mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants