Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trans use of ndmax #14

Open
ameliajo opened this issue Jan 3, 2018 · 0 comments
Open

Trans use of ndmax #14

ameliajo opened this issue Jan 3, 2018 · 0 comments

Comments

@ameliajo
Copy link
Member

ameliajo commented Jan 3, 2018

in trans.h, ndmax is set equal to max(1e6,beta.size()). In s_table_generation, nds / nbt (goes by both names depending on which file we're in) is the number of S_t(a,b) values that were computed (determined by how quickly the S_t(a,bi) values get small).

According to s_table_generation, nds / nbt could be as big as ndmax. But when we inevitably go to sbfill.h, it throws an error if nds is greater than 0.5*ndmax. So that is already a problem that could be caught further upstream.

But what's more is that I don't particularly see why we need to define ndmax so early, could we just set ndmax equal to 2*nds? The only problem we'd have to work around is the fact that ndmax is used before we actually calculate nds, but we could mess with that a bit I think. Just want to avoid throwing an error to the user that could potentially be avoided. Also 1e6 is a lot of space that might not necessarily be necessary to reserve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant