Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coldHydrogen_util.betaLoop_util failed #49

Open
jlconlin opened this issue Nov 13, 2020 · 2 comments
Open

coldHydrogen_util.betaLoop_util failed #49

jlconlin opened this issue Nov 13, 2020 · 2 comments

Comments

@jlconlin
Copy link
Member

I tried compiling/testing. It compiles fine, but one test fails:

1: /Users/jlconlin/NJOY21/Code/leapr/src/coldHydrogen/coldHydrogen_util/betaLoop_util/test/jprimeLoop.test.cpp:98: FAILED:
1:   REQUIRE( out == Approx(0.161404).epsilon(1e-6) )
1: with expansion:
1:   0.161370993 == Approx( 0.161404 )
1:
1: ===============================================================================
1: test cases:  2 |  1 passed | 1 failed
1: assertions: 12 | 11 passed | 1 failed
1:
1/1 Test #1: coldHydrogen.coldHydrogen_util.betaLoop_util ...***Failed    0.01 sec
@jlconlin
Copy link
Member Author

jlconlin commented Nov 13, 2020

The difference is fairly small, but is larger that 1e-6 that is specified on the test. I'll let @ameliajo decide what the best course of action is to fix this.

@ameliajo
Copy link
Member

Hey, thanks for pointing this out. I don't think I included enough sigfigs when checking, so I'm raising the tolerance of this test from 1e-6 --> 1e-5 so it passes. @jlconlin would you be able to check the fix/coldH_testing branch to see if that passes for you? It passed on mine with 1e-6, hence why I missed this. This is just to pass everything now, and I'll write new test cases for coldh when the ENDFtk capability for +/- beta output is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants