Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Eigen version to 3.4.1 or 4.0.0 once it is released #62

Open
whaeck opened this issue Oct 11, 2023 · 0 comments
Open

Set Eigen version to 3.4.1 or 4.0.0 once it is released #62

whaeck opened this issue Oct 11, 2023 · 0 comments

Comments

@whaeck
Copy link
Member

whaeck commented Oct 11, 2023

Eigen 3.4.0 was released in August of 2021. While the library has been working perfectly fine for us, there is one little issue that has proven to be quite annoying: Eigen's unit tests are registered with ctest unless we set BUILD_TESTING to OFF because Eigen 3.4.0 does not have an Eigen specific BUILD_TESTING guard. This is actually not something one wants to do (since BUILD_TESTING is the global cmake variable for testing).

However, the 3.4.1 branch (not a tag, this is important) has been updated in July of 2023 with a cmake fix that resolve this. Scion currently uses the July 26, 2023 commit that made this change instead of the original 3.4.0 tag. Once either the 3.4.1 or a higher verison of Eigen is released, we should move to that release as soon as possible.

This issue is opened as a reminder to check for a new Eigen release from time to time. Once a new version of Eigen is released, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant