Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing newton again #66

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fixing newton again #66

merged 1 commit into from
Nov 17, 2023

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Nov 16, 2023

An issue occurred with U235 while linearising elastic angular distributions at high energy. This was tracked down to an issue in the newton method used to smooth the roots of the Legendre series.

@whaeck whaeck requested a review from BobbiRiedel November 16, 2023 18:40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test if the f(X) at that value is already zero so you avoid to loop through newton method.

Copy link

@BobbiRiedel BobbiRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@whaeck whaeck merged commit 9c71b98 into develop Nov 17, 2023
8 checks passed
@whaeck whaeck deleted the fix/newton-u235 branch November 17, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants