Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/operations #67

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Fix/operations #67

merged 5 commits into from
Feb 14, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Nov 30, 2023

The following changes have been made:

  • an interpolation table can no longer have a jump at the start (this interferes with the construction of the interpolation::Table objects used under the hood)
  • when an operation is performed on two InterpolationTable objects, a jump is now also added if the starting points in the x grid are not the same (previously, this was only done when the last value in the x grids were different)
  • after an operation is performed, potential duplicate x,y (that can occur when the x grids do not have the same starting value) at the threshold value are removed

@whaeck whaeck merged commit 1e99fd2 into develop Feb 14, 2024
8 checks passed
@whaeck whaeck deleted the fix/operations branch February 14, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobbiRiedel BobbiRiedel BobbiRiedel approved these changes

@nathangibson14 nathangibson14 Awaiting requested review from nathangibson14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whaeck @BobbiRiedel