Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License Info with Well-known MIT Classifier #80

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

macserv
Copy link
Contributor

@macserv macserv commented Nov 13, 2024

I am currently unable to utilize nodejs-wheel-binaries at my place of work because the (industry-standard) managed system we use to procure external code can not identify the license type.

This change replaces the current license property with the registered classifier for the MIT License, ensuring that it will be parsed properly by managed procurement tools like ours.

  • Update license data in pyproject.toml, replacing license property with the License :: OSI Approved :: MIT License entry in classifiers.

I am currently unable to utilize `nodejs-wheel-binaries` at my place of work because the (industry-standard) managed system we use to procure external code can not identify the license type.

This change replaces the current `license` property with the registered classifier for the MIT License, ensuring that it will be parsed properly by managed procurement tools like ours.

* Update license data in `pyproject.toml`, replacing `license` property with classifiers, containing the ``License :: OSI Approved :: MIT License`` classifier.
@njzjz njzjz enabled auto-merge (squash) November 13, 2024 20:03
@njzjz
Copy link
Owner

njzjz commented Nov 13, 2024

While I don't oppose this PR as a workaround for your system, I want to point out that the license classifiers have been deprecated in PEP 639.

@macserv
Copy link
Contributor Author

macserv commented Nov 13, 2024

While I don't oppose this PR as a workaround for your system, I want to point out that the license classifiers have been deprecated in PEP 639.

That's a really good catch... I'll make sure that our systems are compliant with that change.

@njzjz njzjz merged commit 6ac0bbc into njzjz:master Nov 13, 2024
9 checks passed
@macserv macserv deleted the patch-1 branch November 15, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants