Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-height 1.4 token between 1.25 and 1.5 #2550

Open
Robbert opened this issue Oct 9, 2024 · 0 comments
Open

line-height 1.4 token between 1.25 and 1.5 #2550

Robbert opened this issue Oct 9, 2024 · 0 comments

Comments

@Robbert
Copy link
Member

Robbert commented Oct 9, 2024

There were a couple of instances where the line-height was outside our custom scale

We now have:

{
      "line-height": {
        "xs": { "value": "1" },
        "sm": { "value": "1.25" },
        "md": { "value": "1.5" },
        "lg": { "value": "2" }
      }
}

So we don't have 1.4. For the following tokens we had set it at component level to 1.4:

  • utrecht.form-fieldset.legend.line-height
  • utrecht.figure.caption.line-height

I have changed them to 1.5 to be md, but perhaps we should introduce a new token in the scale so we can restore 1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant