From 26f862e71b634c073be6468dc233f2239599f875 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marius=20Andr=C3=A9=20Elsfjordstrand=20Beck?=
 <marius.beck@nb.no>
Date: Mon, 8 Jan 2024 13:43:38 +0100
Subject: [PATCH] fix: appending to a slice modifies the slice

This fixes a subtle bug that occurs because the code is reusing a
slice to create two new slices by apping to it.

The problem is that golang modifies the slice being appended to for
performance reasons.
---
 internal/tikvidx/iter.go | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/internal/tikvidx/iter.go b/internal/tikvidx/iter.go
index c97f2fc..3be5fd3 100644
--- a/internal/tikvidx/iter.go
+++ b/internal/tikvidx/iter.go
@@ -84,10 +84,6 @@ func newClosestIter(ctx context.Context, client *rawkv.Client, req index.Request
 		return nil, err
 	}
 
-	prefix, startKey := keyvalue.ClosestWithPrefix(req, cdxPrefix)
-	forwardEndKey := append(prefix, endDate...)
-	backwardEndKey := append(prefix, startDate...)
-
 	limit := req.Limit()
 	if limit == 0 || limit > rawkv.MaxRawKVScanLimit {
 		limit = rawkv.MaxRawKVScanLimit
@@ -103,9 +99,24 @@ func newClosestIter(ctx context.Context, client *rawkv.Client, req index.Request
 	forwardChannel := make(chan maybeKV)
 	backwardChannel := make(chan maybeKV)
 
+	prefix, startKey := keyvalue.ClosestWithPrefix(req, cdxPrefix)
+
+	pf := make([]byte, len(prefix))
+	copy(pf, prefix)
+	forwardEndKey := append(pf, endDate...)
+
+	pb := make([]byte, len(prefix))
+	copy(pb, prefix)
+	backwardEndKey := append(pb, startDate...)
+
+	forwardStartKey := make([]byte, len(startKey))
+	copy(forwardStartKey, startKey)
+	backwardStartKey := make([]byte, len(startKey))
+	copy(backwardStartKey, startKey)
+
 	done := make(chan struct{})
-	go repeatScan(fScanner, startKey, forwardEndKey, forwardChannel, done)
-	go repeatScan(bScanner, startKey, backwardEndKey, backwardChannel, done)
+	go repeatScan(fScanner, forwardStartKey, forwardEndKey, forwardChannel, done)
+	go repeatScan(bScanner, backwardStartKey, backwardEndKey, backwardChannel, done)
 
 	iter := &closestIter{
 		cmp:      timestamp.CompareClosest(t.Unix()),
@@ -197,7 +208,10 @@ func newIter(ctx context.Context, key []byte, client *rawkv.Client, req index.Re
 	if limit == 0 || limit > rawkv.MaxRawKVScanLimit {
 		limit = rawkv.MaxRawKVScanLimit
 	}
-	endKey := append(key, 0xff)
+	endKey := make([]byte, len(key))
+	copy(endKey, key)
+	endKey = append(endKey, 0xff)
+
 	var scan scanner
 	if req.Sort() == index.SortDesc {
 		scan = func(key []byte, endKey []byte) ([][]byte, [][]byte, error) {