Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Flask Configuration Handling #80

Open
tschaffter opened this issue Nov 9, 2020 · 2 comments
Open

Consider using Flask Configuration Handling #80

tschaffter opened this issue Nov 9, 2020 · 2 comments
Labels
Enhancement New feature or request Priority: Low

Comments

@tschaffter
Copy link
Member

https://flask.palletsprojects.com/en/1.1.x/config/

@tschaffter tschaffter added the Enhancement New feature or request label Nov 9, 2020
@tschaffter
Copy link
Member Author

@thomasyu888 Here is how we handle the data node configuration. Could you tell me what you think of this implementation?

@thomasyu888
Copy link
Member

@tschaffter , I don't think theres anything particularly wrong with the way we are doing it. That being said, it may be nicer to use an already available tool to handle the data node creation instead of relying on custom code.

I took a look, and it seems like config.py is something you wrote - not autogenerated. I don't have a strong preference, this seems like a "nice to have", but isn't a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants