Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running submission to be stopped #29

Open
tschaffter opened this issue Feb 3, 2021 · 8 comments
Open

Enable running submission to be stopped #29

tschaffter opened this issue Feb 3, 2021 · 8 comments
Assignees
Labels
Enhancement New feature or request Priority: Low

Comments

@tschaffter
Copy link
Member

Submitters have the option to cancel their submission as long as the submission has not started yet. However, it happens that submitters contact us to stop their submissions when they notice that they did a mistake - or they added a while(true) somewhere - and don't want their quota to be eaten.

Describe how to stop a running submission and perform necessary actions to make sure that the following submissions in the queues can continue running. Describe whether an action has to be performed regarding the "restoration" of the quota.

@tschaffter tschaffter added the Enhancement New feature or request label Feb 3, 2021
@tschaffter tschaffter reopened this Feb 3, 2021
@tschaffter tschaffter changed the title Document how to stop a running submission Enablea running submission to be stopped Mar 17, 2021
@tschaffter tschaffter changed the title Enablea running submission to be stopped Enable running submission to be stopped Apr 14, 2021
@tschaffter
Copy link
Member Author

@thomasyu888 Any update on adding this feature? Can we copy/paste the solution used in other challenges?

@tschaffter
Copy link
Member Author

Tom said:

Cancelling submissions is something that we already support but I found that it didn't work well
The orchestrator would fail

@thomasyu888
Copy link
Member

thomasyu888 commented Apr 15, 2021

@tschaffter I think what I need to do is spend a lot of time testing the cancel feature, because it caused a lot of problems for one challenge that we originally had implemented so I disabled it from then on.

@thomasyu888
Copy link
Member

thomasyu888 commented Jun 28, 2021

@tschaffter Cancelling submissions can be done like this: https://www.synapse.org/#!Synapse:syn22277124/wiki/611450. Any submissions that are processing on the i2b2 dataset can be cancelled, but not on the internal queues. A red "cancel" button will appear in the "cancelControl" column.

Unfortunately, it can't be part of the dashboard table because the "cancelcontrol" type isn't supported in submission views.

@tschaffter
Copy link
Member Author

@thomasyu888 Thanks for the update. Can you contact the Synapse team to ask them to support this cancelcontrol type button?

@thomasyu888
Copy link
Member

@tschaffter I'll see if I filed a jira for this in the past already. I don't think it will be an easy addition as this feature is explicitly for queues and adding cancelcontrol as a column render type affects all tables in Synapse. The hack would be to have a cancel submissions page, but would sort of duplicate the dashboard pages...

@tschaffter
Copy link
Member Author

The hack would be to have a cancel submissions page, but would sort of duplicate the dashboard pages

@thomasyu888 I don't dislike the idea. We could add a page to the Dashboard section that list all the submissions the user is entitled to cancel.

@thomasyu888
Copy link
Member

@tschaffter This JIRA ticket: https://sagebionetworks.jira.com/browse/PLFM-6257 states that these won't be added to submission views. Ya, we could definitely add to the dashboard pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants