-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] If you have sleeper playoffs set to OFF the leagueRecords.js calculations are all broken. #283
Comments
I think it's related to the winners_bracket and losers_bracket promises never resolving possible? Haven't found it exaclty yet but I think that's a root cause maybe... so curSeason always = curSeason and never equals 0 cuz it never updates to lastYear's value type thing maybe? |
I have tried all day to get this to some how work and I am afraid my novice skills are not good enough to figure it out! And I submitted that value to processPlayoffs() and run an if/else inside process playoffs and if the hasPlayoffs is false I return:
I tried returning 'null' for each one, and {} for each one and nothing ever keeps me from getting stuck in an endless loop up in this area:
Where hat last curly-brace is th end of the While(curSeason && curSeason != "0") loop. Somehow the not processing the playoffs is leaving the curSeason and the year the same forever and I can't for the life of me figure out how to update it ... THANKS!! AMAzing code base for this novice to work with, but I think I am at my wit's end! |
Hey! Sorry for the delay @JimNayzium. If you can send me where in leagueData that I can see whether a league doesn't have playoffs, I should be able to get this working. |
Describe the bug
With playoffs on sleeper set to NONE the records page gets hung up.
Your League ID
972236561200799744
I think if you use my leagueID you can see what I mean.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
That it would follow logic to skip over the processPlayoffs if hte playoffs are set to none in leagueData.
THANKS for all this code base, it's really great.
The text was updated successfully, but these errors were encountered: