Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclassify NMR devices according to their ontological nature and only infer the grouping by manufacturer #41

Open
StroemPhi opened this issue Aug 29, 2024 · 0 comments
Labels
discussion This issue still needs discussion before resolving

Comments

@StroemPhi
Copy link
Contributor

StroemPhi commented Aug 29, 2024

NMR instruments are currently defined along the axis of who their manufacturer is as well as along the actual type/kind. The latter was originally done wrong, as there was a GDC class called 'NMR instrument type' whose children were per their textual definition material entities. So we moved them under OBI:device as part of fixing #12. Now, we need to check which NMR instruments that are classified via their manufacturer are of which actual kind/type.

For example, here we see that the Brucker Capillary LC-NMR instrument is not classified as a Capillary LC-NMR instrument
grafik

I propose to rather classify the NMR instruments directly (assert subclassOf axioms) according to their type and not their manufacturer. The latter we should rather do via inference, by logically defining the grouping classes that classify via manufacturer, see for example:
grafik
grafik

As can be seen in the above example, some children are not named/labeled sufficiently to know that they are from a certain manufacturer, hence this would have to be changed in fixing this issue as well.

@NRayya NRayya added the discussion This issue still needs discussion before resolving label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue still needs discussion before resolving
Projects
None yet
Development

No branches or pull requests

2 participants