You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NMR instruments are currently defined along the axis of who their manufacturer is as well as along the actual type/kind. The latter was originally done wrong, as there was a GDC class called 'NMR instrument type' whose children were per their textual definition material entities. So we moved them under OBI:device as part of fixing #12. Now, we need to check which NMR instruments that are classified via their manufacturer are of which actual kind/type.
For example, here we see that the Brucker Capillary LC-NMR instrument is not classified as a Capillary LC-NMR instrument
I propose to rather classify the NMR instruments directly (assert subclassOf axioms) according to their type and not their manufacturer. The latter we should rather do via inference, by logically defining the grouping classes that classify via manufacturer, see for example:
As can be seen in the above example, some children are not named/labeled sufficiently to know that they are from a certain manufacturer, hence this would have to be changed in fixing this issue as well.
The text was updated successfully, but these errors were encountered:
NMR instruments are currently defined along the axis of who their manufacturer is as well as along the actual type/kind. The latter was originally done wrong, as there was a GDC class called 'NMR instrument type' whose children were per their textual definition material entities. So we moved them under OBI:device as part of fixing #12. Now, we need to check which NMR instruments that are classified via their manufacturer are of which actual kind/type.
For example, here we see that the Brucker Capillary LC-NMR instrument is not classified as a Capillary LC-NMR instrument
I propose to rather classify the NMR instruments directly (assert subclassOf axioms) according to their type and not their manufacturer. The latter we should rather do via inference, by logically defining the grouping classes that classify via manufacturer, see for example:
As can be seen in the above example, some children are not named/labeled sufficiently to know that they are from a certain manufacturer, hence this would have to be changed in fixing this issue as well.
The text was updated successfully, but these errors were encountered: