Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a vanity import path at "nmstate.io/nmpolicy" #53

Open
qinqon opened this issue Nov 29, 2021 · 4 comments
Open

Create a vanity import path at "nmstate.io/nmpolicy" #53

qinqon opened this issue Nov 29, 2021 · 4 comments
Labels
kind/enhancement New feature or request

Comments

@qinqon
Copy link
Member

qinqon commented Nov 29, 2021

Following the path like other projects like kubevirt or k8s are consumed by other projects, maybe nmpolicy that is going to be consumed by kubernetes-nmstate and other projects need a vanity import like nmstate.io/nmpolicy that points to github.com/nmstate/nmpolicy, so the project is not stick to github.

One possible implementation is modify the "nmstate.io" page header and add the following meta:

<meta name="go-import" content="nmstate.io/nmpolicy git https://github.com/nmstate/nmpolicy">

This is how it's done at kubevirt: https://github.com/kubevirt/kubevirt.github.io/blob/main/_includes/head.html#L6-L18

Another alternative is to use a subdomain like go.nmstate.io similart to go.uber.org or go.opencensus.io so we don't have to modify the main webpage at nmstate.io.

@EdDev
Copy link
Member

EdDev commented Dec 1, 2021

If I understand this right, the motivation is to avoid being dependent on github.com?
Lets assume that a decision is taken to use some other source control hosting platform, can't we just do it then and declare a new version?

@EdDev
Copy link
Member

EdDev commented Dec 1, 2021

I must say, that I do not mind or have any hard opinion on this. I just want to "warn" about the domain, which is actually owned by Red Hat and not by any community organization.
In fact, most domains will be owned by someone, making that the dependency instead of github, so I am not sure if that is any better.

@qinqon
Copy link
Member Author

qinqon commented Dec 1, 2021

Right, same happends with kubevirt.io, I suppose it's owner by RedHat, but my main concern is that if we change to vanity imports when this project start to have some users (it's not like is going to be huge) we may end up with issues, but I think they are not that bad.

@qinqon
Copy link
Member Author

qinqon commented Dec 1, 2021

/kind enhancement

@github-actions github-actions bot added the kind/enhancement New feature or request label Dec 1, 2021
@qinqon qinqon removed the enhancement label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants