Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDraggedFromTabフラグをなくしたい #19

Open
nnsnico opened this issue Jan 10, 2021 · 1 comment
Open

isDraggedFromTabフラグをなくしたい #19

nnsnico opened this issue Jan 10, 2021 · 1 comment

Comments

@nnsnico
Copy link
Owner

nnsnico commented Jan 10, 2021 •
edited
Loading

  • footerとkeyboardでkeycap componentを共有している
  • D&DをしたりするときにどこからD&Dされているかで振る舞い方が変わる。
    • 今はこれを親componentからフラグを持ってきて判別している(isDraggedFromTab)

共通のDOMとしてcomponentを持ちつつ、振る舞いだけ変えれるようにリファクタリングしたい。
@nnsnico nnsnico changed the title footer内かkeyboard componentでkeycap componentの振る舞い方が違うのでいい感じに分けたい footer内かkeyboard内にあるかでkeycap componentの振る舞い方が違うのでいい感じに分けたい Jan 10, 2021
@nnsnico
Copy link
Owner Author

nnsnico commented Jan 10, 2021 •
edited
Loading

使いたいPropsだけ渡すために FooterKeycap と KeyboardKeycap に分けて、共通のDOMとして現状の Keycap componentを使うようにする？

@nnsnico nnsnico changed the title footer内かkeyboard内にあるかでkeycap componentの振る舞い方が違うのでいい感じに分けたい isDraggedFromTabフラグをなくしたい Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nnsnico