[Subgraph] Implement SubGraphBase/SubGraphCpu to update NetworkGraph; adding graph_scope property
#2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
skykongkong8
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
If I understood correctly, this PR aims to move almost all the basic functionalities of networkGraph to some instances of subgraph, which can have different compute engine backends variants in order to govern them! (CPU, GPU, ... )
Detailed explanations per commit helped my understanding a LOT! Really appreciate it😁
Looks Good to me!
…bGraphBase` - Moved the defined behavior from `NetworkGraph` to `SubGraphBase`. - Updated public methods of `NetworkGraph` to pass their behaviors to `SubGraphBase`. - Removed unused private methods in `NetworkGraph`. Signed-off-by: Eunju Yang <[email protected]>
…o SubGraphBase - Update the definition of forwarding operations in neuralnet to be defined within each subgraph type. - Modify the implementation so that both forwarding and incremental_forwarding can now be defined individually for each subgraph type. Signed-off-by: Eunju Yang <[email protected]>
- Update the definition of backwarding operations in neuralnet to be defined within each subgraph type. - `applyGradients` is also updated without taking any callback from outside. Signed-off-by: Eunju Yang <[email protected]>
… tests - Updated `SubGraphBase` to inherit `GraphNode` - Changed the `graph` type inside `NetworkGraph` from `SubGraphBase` to `GraphCore`, using `SubGraphBase` as its `GraphNode` type. - Allowed for the addition of multiple `SubGraphBase` graph nodes in the future. - Assumed that NetworkGraph always has a `default_subgraph` called default_subgraph, and updated the existing code to maintain compatibility. - Updated the relevant unit test codes. Signed-off-by: Eunju Yang <[email protected]>
- Refactored the input and label setup logic for subgraphs by splitting them into separate functions: `setInputs()` and `setLabels()`. - Introduced new functions `setInputs()` and `setLabels()` to handle input and label setups independently for each subgraph. Signed-off-by: Eunju Yang <[email protected]>
…hCpu` - Updated the base class `SubGraphBase` to become a virtual base class and implemented a derived class `SubGraphCpu`. - Set up `NetworkGraph` to default to creating and utilizing one instance of `SubGraphCpu`. - Declared several member functions related to memory management and computation engines as pure virtual functions (=0) in `SubGraphBase`. Signed-off-by: Eunju Yang <[email protected]>
- This commit adds a `graph_scope` property to designate the subgraph, which a layer belongs to. - This commit updates NetworkGraph's addLayer function to check the GraphName of the layer and create a subgraph if the graph doesn't exist. Signed-off-by: Eunju Yang <[email protected]>
- The previous version didn't implement a constructor for subgraph initialization. - This commit resolves the issue. Signed-off-by: Eunju Yang <[email protected]>
EunjuYang
force-pushed
the
pr/subgraph/base_cpu_property
branch
from
5f32216 to
dcebfd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewers,
Abstract
This PR aims to suggest the first draft to resolve #2864.
This PR implements
SubGraphBasewhich is a virtual class withGraphCore subgraph; thesubgraphmanages the layers included in the subgraph. Also, This PR updatsNetworkGraphto manage multiple subgraph usngGraphCore graph. To this end, it implemented theSubGraphBaseto inheritGraphNode.Please note that, this draft only considers to implement the skeleton, so it doesn't fully consider to support multiple subgraphs. The feature will be added in later PR. However, it would be happy to listen your idea on managing multiple subgraphs.
List of commits
NetworkGraphtoSubGraphBase.NetworkGraphto pass their behaviors toSubGraphBase.NetworkGraph.applyGradientsis also updated without taking any callback fromoutside.
SubGraphBaseto inheritGraphNodegraphtype insideNetworkGraphfromSubGraphBasetoGraphCore, usingSubGraphBaseas itsGraphNodetype.SubGraphBasegraph nodes in the future.default_subgraphcalled default_subgraph, and updated the existing code to maintain compatibility.setInputs()andsetLabels().setInputs()andsetLabels()to handle input and label setups independently for each subgraph.SubGraphBaseto become a virtual base class and implemented a derived classSubGraphCpu.NetworkGraphto default to creating and utilizing one instance ofSubGraphCpu.SubGraphBase.graph_scopeproperty to designate the subgraph,which a layer belongs to.
GraphName of the layer and create a subgraph if the graph doesn't
exist.
Self evaluation: