From 71804ad4488492471da9971d564aee76e648c94f Mon Sep 17 00:00:00 2001
From: Fariborz Daneshvar
 <132295102+FariborzDaneshvar-NOAA@users.noreply.github.com>
Date: Thu, 11 Apr 2024 09:27:14 -0700
Subject: [PATCH] Fix cor in plot (#141)

* update the corr value when denominator is zero

* format surrogate.py with oitnb
---
 ensembleperturbation/plotting/surrogate.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ensembleperturbation/plotting/surrogate.py b/ensembleperturbation/plotting/surrogate.py
index bf2e0681..c0614571 100644
--- a/ensembleperturbation/plotting/surrogate.py
+++ b/ensembleperturbation/plotting/surrogate.py
@@ -26,8 +26,10 @@ def corrcoef(O, P):
         OD2 = ((O - MO) ** 2).sum()
         PDOD = ((P - MP) * (O - MO)).sum()
         corr = PDOD / (PD2 * OD2) ** 0.5
-        if numpy.isnan(corr.values):
+        if (PDOD == 0) & (PD2 == 0) & (OD2 == 0):
             corr.values = 1.0  # 0/0: perfect correlation
+        elif (PD2 == 0) or (OD2 == 0):
+            corr.values = 0.0  # No./0: no-correlation
         return corr
 
     # correlation coefficient