Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es6 class inheritance #23

Closed
maxnowack opened this issue Nov 23, 2016 · 4 comments · May be fixed by #24
Closed

es6 class inheritance #23

maxnowack opened this issue Nov 23, 2016 · 4 comments · May be fixed by #24

Comments

@maxnowack
Copy link

It would be great if noble-device can be used with es6 features such as classes and promises
@sandeepmistry
Copy link
Collaborator

Hi @maxnowack,

Do you think this would be a breaking change, and force users to upgrade to a newer Node.js version?

Feel free to submit a PR with a proposal to get the discussion started ...

@sandeepmistry sandeepmistry reopened this Nov 26, 2016
@maxnowack
Copy link
Author

I don't think that this will be a breaking change. Basically we have to move the prototype changes from the inherit util directly to the NobleDevice prototype.
Is there a reason why the changes are currently done in this way?

@maxnowack
Copy link
Author

maxnowack commented Dec 5, 2016 •
edited
Loading

Ah. Statics, not prototype methods. I'll submit a PR ;)

maxnowack added a commit to maxnowack/noble-device that referenced this issue Dec 5, 2016
@maxnowack
enable es6 class inheritance
d9515a7 
resolves noble#23

It seems that the tests are broken even without my change. This should
be fixed before merging to ensure the compatibility to older versions.
@maxnowack maxnowack mentioned this issue Dec 5, 2016
Open
maxnowack added a commit to maxnowack/noble-device that referenced this issue Dec 5, 2016
@maxnowack
enable es6 class inheritance
b13f2af 
resolves noble#23

It seems that the tests are broken even without my change. This should
be fixed before merging to ensure the compatibility to older versions.
maxnowack added a commit to maxnowack/noble-device that referenced this issue Dec 5, 2016
@maxnowack
enable es6 class inheritance
d3d04bd 
resolves noble#23

It seems that the tests are broken even without my change. This should
be fixed before merging to ensure the compatibility to older versions.
@sandeepmistry
Copy link
Collaborator

Closing this for now, please open a PR to continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable es6 class inheritance maxnowack/noble-device
2 participants
@maxnowack @sandeepmistry