Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed loop unrolls #12

Open
GMNGeoffrey opened this issue Jan 22, 2025 · 0 comments
Open

Failed loop unrolls #12

GMNGeoffrey opened this issue Jan 22, 2025 · 0 comments
Assignees

Comments

@GMNGeoffrey
Copy link
Collaborator

We get some compiler warnings about loop unrolling failing, like this:

/home/gcmn/src/dgl/third_party/HugeCTR/gpu_cache/src/nv_gpu_cache.cu:64:3: warning: loop not unrolled: the optimizer was unable to perform the requested transformation; the transformation might be disabled or specified as part of an unsupported transformation ordering [-Wpass-failed=transform-warning]
   64 |   for (size_t i = lane_idx; i < emb_vec_size_in_float; i += warp_size) {
      |   ^

Based on discussions like NVIDIA/cub#246 and https://gitlab.com/libeigen/eigen/-/issues/1751, I suspect this isn't a big deal and the explicit compiler pragma should actually maybe be removed or the warning silenced. Unclear if that's a change that should go upstream.

@GMNGeoffrey GMNGeoffrey self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant