From 4a051f1881861580956121b030fe16593f79546c Mon Sep 17 00:00:00 2001 From: yzhang93 Date: Thu, 29 Aug 2024 14:47:12 -0700 Subject: [PATCH] Add comments back --- build_tools/ci/run_matmul_test.sh | 4 ++++ .../iree-amd-aie/Transforms/test/lowering_strategy.mlir | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/build_tools/ci/run_matmul_test.sh b/build_tools/ci/run_matmul_test.sh index 6685a6f13..32fcac59f 100755 --- a/build_tools/ci/run_matmul_test.sh +++ b/build_tools/ci/run_matmul_test.sh @@ -551,6 +551,10 @@ if [ -d "$VITIS" ]; then --use_ukernel "1" fi +# Example of a run with a group of 2+ matmuls. Currently this test is passed +# the flag '--num_repeat_runs 0" as there is currently an issue with the runtime if +# multiple matmuls are run in the same test. TODO(newling/nmeshram): Document +# this issue. run_matmul_test \ --name_prefix "multiple_matmuls" \ --lower_to_aie_pipeline "air" \ diff --git a/compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy.mlir b/compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy.mlir index 872d627a2..8c7546d78 100644 --- a/compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy.mlir +++ b/compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/lowering_strategy.mlir @@ -1,5 +1,5 @@ -// RUN: iree-opt --split-input-file --pass-pipeline='builtin.module(iree-amdaie-lowering-strategy{use-pass-pipeline=pad-pack})' %s | FileCheck %s --check-prefix=CHECK-PAD-PACK -// RUN: iree-opt --split-input-file --pass-pipeline='builtin.module(iree-amdaie-lowering-strategy{use-pass-pipeline=pack-peel})' %s | FileCheck %s --check-prefix=CHECK-PACK-PEEL +// RUN: iree-opt --split-input-file --pass-pipeline='builtin.module(iree-amdaie-lowering-strategy{use-lower-to-aie-pipeline=air use-pass-pipeline=pad-pack})' %s | FileCheck %s --check-prefix=CHECK-PAD-PACK +// RUN: iree-opt --split-input-file --pass-pipeline='builtin.module(iree-amdaie-lowering-strategy{use-lower-to-aie-pipeline=air use-pass-pipeline=pack-peel})' %s | FileCheck %s --check-prefix=CHECK-PACK-PEEL // CHECK-PAD-PACK{LITERAL}: #config = #iree_codegen.lowering_config // CHECK-PAD-PACK{LITERAL}: #packingConfig = #amdaie.packing_config