From 95792af203773b93a723a1da31c80a86d49b570f Mon Sep 17 00:00:00 2001
From: Scott Todd <scott.todd0@gmail.com>
Date: Thu, 17 Oct 2024 07:46:08 -0700
Subject: [PATCH] Skip crashing shortfin python tests on Windows. (#289)

Follow-up to https://github.com/nod-ai/SHARK-Platform/pull/269.

Something about this error handling is crashing the process without
useful logs:
https://github.com/nod-ai/SHARK-Platform/actions/runs/11373400662/job/31639876327?pr=288#step:9:131

Until we can debug that further, skip the affected tests on Windows.
---
 shortfin/tests/api/array_storage_test.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/shortfin/tests/api/array_storage_test.py b/shortfin/tests/api/array_storage_test.py
index 24055b031..d65452013 100644
--- a/shortfin/tests/api/array_storage_test.py
+++ b/shortfin/tests/api/array_storage_test.py
@@ -5,6 +5,7 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 import pytest
+import sys
 
 import shortfin as sf
 import shortfin.array as sfnp
@@ -68,6 +69,9 @@ async def main():
     lsys.run(main())
 
 
+@pytest.mark.skipif(
+    sys.platform == "win32", reason="Windows fatal exception: access violation"
+)
 def test_fill_error(device):
     s = sfnp.storage.allocate_host(device, 8)
     with pytest.raises(RuntimeError):
@@ -80,6 +84,9 @@ def test_fill_error(device):
         s.fill(b"01234567")
 
 
+@pytest.mark.skipif(
+    sys.platform == "win32", reason="Windows fatal exception: access violation"
+)
 @pytest.mark.parametrize(
     "pattern,size",
     [