From e906b669b071d1804704b619910b6774f0604070 Mon Sep 17 00:00:00 2001 From: Stephen Baione <109226581+stbaione@users.noreply.github.com> Date: Mon, 25 Nov 2024 10:53:50 -0600 Subject: [PATCH] See if stale dependencies are causing shortfin server to fail to start (#604) # Description We started seeing a failure in `Shortfin CPU LLM Integration Test` after merging #601. However, the only aspect of the integration test that that PR touches is a fix in the logger: Old ```python logger = logging.getLogger("__name__") ``` New ```python logger = logging.getLogger(__name__) ``` That shouldn't have an impact on the test, and while reading the output of the workflow, it didn't seem to be the line that caused the server to not start. When testing locally in a fresh environment, the test ran fine, which made me think that it may be related to stale dependencies. I updated the hash of cached pip to take into account requirement changes in `sharktank` and `shortfin`, which appears to fix the test. --- .github/workflows/ci-shark-ai.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-shark-ai.yml b/.github/workflows/ci-shark-ai.yml index bf8007e65..fc85a76a7 100644 --- a/.github/workflows/ci-shark-ai.yml +++ b/.github/workflows/ci-shark-ai.yml @@ -49,7 +49,7 @@ jobs: id: cache-pip with: path: ${{ env.PIP_CACHE_DIR }} - key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements.txt') }} + key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements*.txt','shortfin/requirements*.txt','sharktank/requirements*.txt') }} - name: Install pip deps run: |