Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dot file #24

Closed
wants to merge 2 commits into from
Closed

feat: support dot file #24

wants to merge 2 commits into from

Conversation

fangk
Copy link

@fangk fangk commented Jun 8, 2016

close: #23

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @popomore, @atian25 and @shepherdwind to be potential reviewers

@fangk fangk changed the title feat: add dao_loader feat: support dot file Jun 8, 2016
getMods(join(fixtures, 'error/dotdir'));
}).should.throw('dot.dir is not match /^[a-z][a-z0-9_-]*$/gi in dot.dir/a.js');
});
// it('should throw when directory contains dot', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这个测试用例改对吧,dot.dir 应该变成怎样

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot.dir也会变成同步支持. 现在好像没法区分是file还是dir

@popomore popomore closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why not support dot file?
6 participants