New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected overwrite falsey value #30

Open

thzt opened this issue Feb 20, 2017 · 0 comments

Contributor

thzt commented Feb 20, 2017

lib/inject.js line 23

if (!isOverride && obj[property]) {    //what about isOverride:false, obj[propery]:0
    throw new Error('can\'t overwrite property ' + property);
}

obj[property] may be Falsey Value, such as 0, '', false ...
these values will be overrided although isOverride is false.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment