Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all ES5 style classes into ES6+ style class #212

Closed
12 tasks done
jankapunkt opened this issue Aug 4, 2023 · 2 comments
Closed
12 tasks done

Move all ES5 style classes into ES6+ style class #212

jankapunkt opened this issue Aug 4, 2023 · 2 comments
Milestone

Comments

@jankapunkt
Copy link
Member

jankapunkt commented Aug 4, 2023

Targeting release 5.0.0 we should complete the ES6+ migration by transforming all ES5-style classes into ES6+ style class constructs.

This currently applies to the following classes:

@jorenvandeweyer
Copy link
Member

jorenvandeweyer commented Aug 26, 2023

@jankapunkt In your issue you said that these PR's should be targeted for the 5.0.0 release.

I'm a bit confused because #223 was merged in development.

Is the development branch for future 4.x releases and if so how are we keeping release-5.0.0 and development in sync?

For example, how would the changes of #228 be merged into 5.0.0, since the changes of #227 would probably create merge conflicts.

@jankapunkt
Copy link
Member Author

@jorenvandeweyer sorry my mistake, development is correct as we will merge development and 5.0.0 anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants