Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom reference.uri is not honored by SignedXml.prototype.createReferences #142

Open
ergoithz opened this issue Oct 4, 2017 · 1 comment

Comments

@ergoithz
Copy link

ergoithz commented Oct 4, 2017

Currently there is no way to customize the reference URI, even if SignedXml.prototype.addReference accepts it as argument, because is always overwritten by xpath id attribute.

https://github.com/yaronn/xml-crypto/blob/6e22854b1aeb4e59bd482a185826361a39872704/lib/signed-xml.js#L584

https://github.com/yaronn/xml-crypto/blob/6e22854b1aeb4e59bd482a185826361a39872704/lib/signed-xml.js#L443

@cjbarth
Copy link
Contributor

cjbarth commented May 29, 2023

@ergoithz , we'd welcome a PR with a test suite to address this limitation in xml-crypto. Would you consider contributing to the community to address this weakness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants