Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pako uses outdated version of zlib which causes problems with other libs #143

Closed
LJNeon opened this issue Jul 15, 2018 · 3 comments
Closed

Comments

@LJNeon
Copy link

LJNeon commented Jul 15, 2018

For example sharp, when I try to use sharp and pako is required first it gives the following error:

Error: /lib/x86_64-linux-gnu/libz.so.1: version `ZLIB_1.2.9' not found (required by /home/ubuntu/workspace/ffa/node_modules/sharp/build/Release/../../vendor/lib/libpng16.so.16)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:718:18)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/ubuntu/workspace/ffa/node_modules/sharp/lib/constructor.js:10:15)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)

I can require sharp first to avoid this error but updating the version pako uses seems much better.

Furthermore, the zlib 1.2.8 version contains a bug which accepts invalid headers when windowBits is zero. This took us a while to figure out, and happens to be fixed in 1.2.9+.

@puzrin
Copy link
Member

puzrin commented Jul 15, 2018

I'm not sure your sharp's problems are related to pako. Anyway, if someone wish to update sources - PR welcome.

@puzrin
Copy link
Member

puzrin commented Jul 26, 2018

I tend to close this, since description is confusing and seems not related to this package. The only correct statement is "pako needs sync with newer zlib". That's indirectly mentioned in #107, but new issue can be created if that helps to anyone

@LJNeon
Copy link
Author

LJNeon commented Jul 26, 2018

Yea I poorly wrote this issue, go ahead and make a new issue for the newer zlib sync.

@LJNeon LJNeon closed this as completed Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants