Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sample app - file share #23

Closed
wants to merge 7 commits into from

Conversation

mrsauravsahu
Copy link
Collaborator

This is a file share app to share file on local network. Should partly close #17

I'm having trouble with Svelte's reactivity. And not sure if it's svelte or our renderer. @shirakaba Can you take a look?
When I drop a new file, a text still shows the old file path.

@mrsauravsahu mrsauravsahu added the do-not-merge Do not merge label Feb 7, 2021
@shirakaba
Copy link
Collaborator

shirakaba commented Feb 7, 2021

Thanks for making this sample app! I’ll look into the reactivity problem later.

Could this sample app be added to https://github.com/nodegui/examples instead of this repo, though? Just that I’d prefer to keep the demo app for this repo super-simple (i.e. a Hello World level of complexity) and leave that as the only demo in the repo so that it remains easy for any contributors to explore or develop a new API by just playing around and modifying the minimal demo app; keeping it basic means there is little for them to subtract when experimenting, and keeping the repo to just one demo app reduces its size when cloning.

Sorry for the trouble!

@mrsauravsahu
Copy link
Collaborator Author

@shirakaba Yeah, I can move it to the examples repo. No worries.
We'll need to push @nodegui/svelte-nodegui to npmjs first though. Let me open a draft PR without the package till then.

@shirakaba
Copy link
Collaborator

We'll need to push @nodegui/svelte-nodegui to npmjs first though. Let me open a draft PR without the package till then.

@mrsauravsahu Just to mention that I haven't forgotten this, I've just been up to other things – I aim to publish at the very least an alpha of @nodegui/svelte-nodegui some time in the next week or two. Provisionally before 23rd Feb. Thanks for your patience!

@mrsauravsahu
Copy link
Collaborator Author

mrsauravsahu commented Feb 24, 2021

Thanks @shirakaba

I've created a pull request in the examples repo. I got an error #26 when starting the app. I've used a workaround for now.
PR: nodegui/examples#38

@mrsauravsahu
Copy link
Collaborator Author

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a sample app
2 participants