Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to avoid writing to package.json #502

Open
ELLIOTTCABLE opened this issue Jun 13, 2014 · 1 comment
Open

Option to avoid writing to package.json #502

ELLIOTTCABLE opened this issue Jun 13, 2014 · 1 comment

Comments

@ELLIOTTCABLE
Copy link

I understand why Nodejitsu needs to define a new "patch version" for new deploys; but my project's package.json is versioned, and is also not formatted the way jitsu insists on formatting JSON. This basically means with each deploy, I have to jitsu deploy to figure out what the patch-number Nodejitsu wants is, terminate the command before it stomps on my file, manually update the patch number, re-issue jitsu deploy, and then revert the file to the patch-number-less format in the repository.

Since npm pack is being used, and the patch-number needs to exist in the package, my suggestion for a solution is thus: copy the entire directory to a temp-location, minus the obviously-ignored node_modules; modify the package.json in the temp directory, npm pack that, and then ship that package off to Nodejitsu.

Obviously, this could / should be under a flag. The simplest usage-flow for most users is simply to let package.json be managed by tools like npm and jitsu for them; those of us manually maintaining it are the outliers.

@baer
Copy link

baer commented Oct 6, 2014

I completely agree - I'm happy to do any package.json modifications required but I DO NOT WANT this to re-write my entire package.json file. I don't want my name on that diff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants