Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different timeouts per request. #17

Open
3rd-Eden opened this issue Oct 17, 2012 · 0 comments
Open

Allow different timeouts per request. #17

3rd-Eden opened this issue Oct 17, 2012 · 0 comments

Comments

@3rd-Eden
Copy link
Member

Currently it's only possible to set a timeout option for the whole client instance and it needs to be really high as deployments and start operation can take various of minutes. But other API calls such as a simple account details call will also be under that same timeout and having a timeout of 8+ minutes will be to damn high for it. As you want to be able to timeout those requests in timely manner.

Suggested API's

// if there are 2 objects in the arguments assume that the last one is options for the request
client.command('username', data, options, callback)

or something signature breaking

client.timeout(5000).command('username', data, callback)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant