Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Checklist #25

Open
davidmarkclements opened this issue Nov 8, 2018 · 2 comments
Open

Review Checklist #25

davidmarkclements opened this issue Nov 8, 2018 · 2 comments

Comments

@davidmarkclements
Copy link
Member

davidmarkclements commented Nov 8, 2018

Please copy the following checklist, paste it into the PR thread and complete when reviewing item PR's:

- [ ] check for typos
- [ ] comprehension – does it make sense, what about to non-native English speakers?
- [ ] files structure - do they match the meta data in the questions markdown doc
- [ ] in the markdown doc, is the goal aligned with task 
- [ ] in the markdown doc, are the correct files hidden 
- [ ] ensure the phase is completed
- [ ] check that the variant number matches the item code
- [ ] assertion code - does it cover all cases/approaches
- [ ] package.json - any stray deps, correctly named etc.
- [ ] is the description correctly duplicated in project folder (IMPORTANT)
- [ ] do supplied answers correctly validate IN NODE 10
- [ ] is the question still relevant in a Node 10 context
@vvscode
Copy link

vvscode commented Nov 8, 2018

don't you want put it to issue template?

@Horaddrim
Copy link

Horaddrim commented Nov 8, 2018

I think this checklist is for the guy who will review the PR, @vvscode, but I think we have to work on an issue template ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants