Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-test-linter failures #4032

Open
StefanStojanovic opened this issue Mar 4, 2025 · 1 comment
Open

node-test-linter failures #4032

StefanStojanovic opened this issue Mar 4, 2025 · 1 comment

Comments

@StefanStojanovic
Copy link
Contributor

Since some time yesterday, node-test-linter job has been failing on all PRs and daily master job (daily v22 job passed today). This is the error:

09:00:28 Error [ERR_REQUIRE_ESM]: require() of ES Module /home/iojs/build/workspace/node-test-linter/tools/eslint/node_modules/@stylistic/eslint-plugin-js/dist/index.js from /home/iojs/build/workspace/node-test-linter/tools/eslint/eslint.config_utils.mjs not supported.
09:00:28 Instead change the require of index.js in /home/iojs/build/workspace/node-test-linter/tools/eslint/eslint.config_utils.mjs to a dynamic import() which is available in all CommonJS modules.
09:00:28     at file:///home/iojs/build/workspace/node-test-linter/eslint.config.mjs?mtime=1741006171417:23:21
09:00:29     at async loadConfigFile (/home/iojs/build/workspace/node-test-linter/tools/eslint/node_modules/eslint/lib/config/config-loader.js:197:21)
09:00:29     at async ConfigLoader.calculateConfigArray (/home/iojs/build/workspace/node-test-linter/tools/eslint/node_modules/eslint/lib/config/config-loader.js:500:32)

This is preventing PRs that require CI from landing.

@richardlau
Copy link
Member

richardlau commented Mar 4, 2025

See nodejs/node#57314.

Updating the version of Node.js on the jenkins-workspace machines used for linting is also an option, if someone has the time to do so (it would involve updating

# Remove old NodeSource repository setup
- name: Get Ubuntu codename
ansible.builtin.command: "lsb_release -s -c"
changed_when: no
check_mode: no
register: release_codename
- name: Remove nodesource 20 repo
apt_repository:
repo: deb https://deb.nodesource.com/node_20.x {{ release_codename.stdout }} main
state: absent
- name: Remove nodesource 16 repo
apt_repository:
repo: deb https://deb.nodesource.com/node_16.x {{ release_codename.stdout }} main
state: absent
- name: Remove old nodesource signing key
apt_key:
url: https://deb.nodesource.com/gpgkey/nodesource.gpg.key
state: absent
# NodeSource distribution
- name: Add nodesource signing key
ansible.builtin.get_url:
dest: /etc/apt/keyrings/nodesource-repo.gpg.asc
url: https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key
- name: Add nodesource 20 repo
apt_repository:
repo: deb [arch=amd64 signed-by=/etc/apt/keyrings/nodesource-repo.gpg.asc] https://deb.nodesource.com/node_20.x nodistro main
state: present
- name: Install node
package:
name: nodejs
state: latest
update_cache: yes
and the re-running Ansible against the jenkins-workspace machines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants