diff --git a/pylib/gyp/generator/make.py b/pylib/gyp/generator/make.py index 32a2122..634da89 100644 --- a/pylib/gyp/generator/make.py +++ b/pylib/gyp/generator/make.py @@ -788,7 +788,7 @@ def __init__(self, generator_flags, flavor): self.suffix_rules_objdir2 = {} # Generate suffix rules for all compilable extensions. - for ext in COMPILABLE_EXTENSIONS: + for ext, value in COMPILABLE_EXTENSIONS.items(): # Suffix rules for source folder. self.suffix_rules_srcdir.update( { @@ -797,7 +797,7 @@ def __init__(self, generator_flags, flavor): $(obj).$(TOOLSET)/$(TARGET)/%%.o: $(srcdir)/%%%s FORCE_DO_CMD \t@$(call do_cmd,%s,1) """ - % (ext, COMPILABLE_EXTENSIONS[ext]) + % (ext, value) ) } ) @@ -810,7 +810,7 @@ def __init__(self, generator_flags, flavor): $(obj).$(TOOLSET)/$(TARGET)/%%.o: $(obj).$(TOOLSET)/%%%s FORCE_DO_CMD \t@$(call do_cmd,%s,1) """ - % (ext, COMPILABLE_EXTENSIONS[ext]) + % (ext, value) ) } ) @@ -821,7 +821,7 @@ def __init__(self, generator_flags, flavor): $(obj).$(TOOLSET)/$(TARGET)/%%.o: $(obj)/%%%s FORCE_DO_CMD \t@$(call do_cmd,%s,1) """ - % (ext, COMPILABLE_EXTENSIONS[ext]) + % (ext, value) ) } ) @@ -1779,13 +1779,13 @@ def WriteTarget( # using ":=". self.WriteSortedXcodeEnv(self.output, self.GetSortedXcodePostbuildEnv()) - for configname in target_postbuilds: + for configname, value in target_postbuilds.items(): self.WriteLn( "%s: TARGET_POSTBUILDS_%s := %s" % ( QuoteSpaces(self.output), configname, - gyp.common.EncodePOSIXShellList(target_postbuilds[configname]), + gyp.common.EncodePOSIXShellList(value), ) ) diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py index 0881cbb..5e71fda 100644 --- a/pylib/gyp/input.py +++ b/pylib/gyp/input.py @@ -2469,11 +2469,8 @@ def SetUpConfigurations(target, target_dict): merged_configurations[configuration] = new_configuration_dict # Put the new configurations back into the target dict as a configuration. - for configuration in merged_configurations: - target_dict["configurations"][configuration] = merged_configurations[ - configuration - ] - + for configuration, value in merged_configurations.items(): + target_dict["configurations"][configuration] = value # Now drop all the abstract ones. configs = target_dict["configurations"] target_dict["configurations"] = { @@ -3020,8 +3017,8 @@ def Load( del target_dict[key] ProcessListFiltersInDict(target_name, tmp_dict) # Write the results back to |target_dict|. - for key in tmp_dict: - target_dict[key] = tmp_dict[key] + for key, value in tmp_dict.items(): + target_dict[key] = value # Make sure every dependency appears at most once. RemoveDuplicateDependencies(targets) diff --git a/tools/pretty_sln.py b/tools/pretty_sln.py index cf0638a..8026699 100755 --- a/tools/pretty_sln.py +++ b/tools/pretty_sln.py @@ -93,10 +93,10 @@ def ParseSolution(solution_file): continue # Change all dependencies clsid to name instead. - for project in dependencies: + for project, deps in dependencies.items(): # For each dependencies in this project new_dep_array = [] - for dep in dependencies[project]: + for dep in deps: # Look for the project name matching this cldis for project_info in projects: if projects[project_info][1] == dep: diff --git a/tools/pretty_vcproj.py b/tools/pretty_vcproj.py index d4b58fd..8624003 100755 --- a/tools/pretty_vcproj.py +++ b/tools/pretty_vcproj.py @@ -118,8 +118,8 @@ def FixFilenames(filenames, current_directory): new_list = [] for filename in filenames: if filename: - for key in REPLACEMENTS: - filename = filename.replace(key, REPLACEMENTS[key]) + for key, value in REPLACEMENTS.items(): + filename = filename.replace(key, value) os.chdir(current_directory) filename = filename.strip("\"' ") if filename.startswith("$"):