Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aa2aa3e534787fc219c66ca6667ad08ee61bb921
Choose a base ref
..
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dce3aefcb5773be08398d6f94587647f4baff878
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/find-visualstudio.js
2 changes: 1 addition & 1 deletion lib/find-visualstudio.js
Original file line number Diff line number Diff line change
@@ -386,7 +386,7 @@ class VisualStudioFinder {
return ret
}
// Fix this when Visual Studio 2025 ships
if ([17, 18].includes(versionMajor)) {
if ([17, 18].includes(ret.versionMajor)) {
ret.versionYear = 2022
return ret
}