Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build bug in target arch config #2865

Open
moccajoghurt opened this issue Jun 5, 2023 · 2 comments · May be fixed by #2941
Open

Build bug in target arch config #2865

moccajoghurt opened this issue Jun 5, 2023 · 2 comments · May be fixed by #2941

Comments

@moccajoghurt
Copy link

node-gyp/lib/configure.js

Line 271 in a26494f

!gyp.opts.nodedir ? '<(target_arch)' : '$(Configuration)',

'<(target_arch)' should be '$(target_arch)'
@moccajoghurt moccajoghurt changed the title Installation error caused by typo Build bug in target arch config Jun 5, 2023
@cclauss cclauss assigned cclauss and unassigned cclauss Jun 5, 2023
@moccajoghurt moccajoghurt mentioned this issue Jun 5, 2023
Closed
@cclauss
Copy link
Contributor

cclauss commented Jun 13, 2023

Is this still an issue on https://github.com/nodejs/node-gyp/releases/tag/v9.4.0 ?

@shazron
Copy link

shazron commented Aug 25, 2023

@cclauss the issue is still present in the main branch https://github.com/nodejs/node-gyp/blob/main/lib/configure.js#L251 so I would think, yes.

@lovell lovell mentioned this issue Oct 12, 2023
Merged
@lukekarrys lukekarrys linked a pull request Nov 3, 2023 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shazron @moccajoghurt @cclauss